Skip to content

Commit

Permalink
Merge pull request #1263 from eddumelendez
Browse files Browse the repository at this point in the history
* pr/1263:
  Polish "Fix testcontainers module location in HELP.md"
  Fix testcontainers module location in HELP.md

Closes gh-1263
  • Loading branch information
snicoll committed Jul 31, 2023
2 parents e125f0d + 5069af7 commit eb7d280
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private static Consumer<Build> addModule(String id) {

private static Consumer<HelpDocument> addReferenceLink(String name, String modulePath) {
return (helpDocument) -> {
String href = String.format("https://www.testcontainers.org/modules/%s", modulePath);
String href = String.format("https://java.testcontainers.org/modules/%s", modulePath);
String description = String.format("Testcontainers %s Reference Guide", name);
helpDocument.gettingStarted().addReferenceDocLink(href, description);
};
Expand Down
2 changes: 1 addition & 1 deletion start-site/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,7 @@ initializr:
bom: testcontainers
links:
- rel: reference
href: https://www.testcontainers.org/
href: https://java.testcontainers.org/
- name: Contract Verifier
bom: spring-cloud
id: cloud-contract-verifier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static Stream<Arguments> referenceLinks() {
@Test
void linkToSupportedEntriesWhenTwoMatchesArePresentOnlyAddLinkOnce() {
assertHelpDocument("testcontainers", "data-mongodb", "data-mongodb-reactive")
.containsOnlyOnce("https://www.testcontainers.org/modules/databases/mongodb/");
.containsOnlyOnce("https://java.testcontainers.org/modules/databases/mongodb/");
}

private static Dependency integrationDependency(String id) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ static Stream<Arguments> supportedEntriesBuild() {
@MethodSource("supportedEntriesHelpDocument")
void linkToSupportedEntriesWhenTestContainerIsPresentIsAdded(String dependencyId, String docHref) {
assertHelpDocument("3.0.0", "testcontainers", dependencyId)
.contains("https://www.testcontainers.org/modules/" + docHref);
.contains("https://java.testcontainers.org/modules/" + docHref);
}

@ParameterizedTest
@MethodSource("supportedEntriesHelpDocument")
void linkToSupportedEntriesWhenTestContainerIsNotPresentIsNotAdded(String dependencyId, String docHref) {
assertHelpDocument("3.0.0", dependencyId).doesNotContain("https://www.testcontainers.org/modules/" + docHref);
assertHelpDocument("3.0.0", dependencyId).doesNotContain("https://java.testcontainers.org/modules/" + docHref);
}

static Stream<Arguments> supportedEntriesHelpDocument() {
Expand All @@ -110,7 +110,7 @@ static Stream<Arguments> supportedEntriesHelpDocument() {
@Test
void linkToSupportedEntriesWhenTwoMatchesArePresentOnlyAddLinkOnce() {
assertHelpDocument("3.0.0", "testcontainers", "data-mongodb", "data-mongodb-reactive")
.containsOnlyOnce("https://www.testcontainers.org/modules/databases/mongodb/");
.containsOnlyOnce("https://java.testcontainers.org/modules/databases/mongodb/");
}

@Test
Expand Down

0 comments on commit eb7d280

Please sign in to comment.