Add Spring Modulith #1228
Closed
Add Spring Modulith #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
requested changes
Jun 30, 2023
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Outdated
Show resolved
Hide resolved
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Show resolved
Hide resolved
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Outdated
Show resolved
Hide resolved
...t/site/extension/dependency/springmodulith/SpringModulithProjectGenerationConfiguration.java
Show resolved
Hide resolved
...t/site/extension/dependency/springmodulith/SpringModulithProjectGenerationConfiguration.java
Outdated
Show resolved
Hide resolved
...ite/src/main/java/io/spring/start/site/extension/dependency/springmodulith/package-info.java
Show resolved
Hide resolved
...pring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizerTests.java
Show resolved
Hide resolved
...pring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizerTests.java
Outdated
Show resolved
Hide resolved
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Outdated
Show resolved
Hide resolved
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Outdated
Show resolved
Hide resolved
odrotbohm
force-pushed
the
hacking/spring-modulith
branch
4 times, most recently
from
ddc2f06
to
728cbfc
Compare
|
All changes in place as requested. |
snicoll
requested changes
Jul 7, 2023
There was a problem hiding this comment.
Thanks for the PR. I've added a few comments for your consideration.
I know building the client is an issue due to installing node-gyp. If you don't want to install it, you can remove the following dependency locally:
<dependency>
<groupId>io.spring.start</groupId>
<artifactId>start-client</artifactId>
<scope>runtime</scope>
</dependency>And then run the following command: ./mvnw verify -pl start-site. Thanks!
.../io/spring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizer.java
Outdated
Show resolved
Hide resolved
...pring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizerTests.java
Outdated
Show resolved
Hide resolved
...pring/start/site/extension/dependency/springmodulith/SpringModulithBuildCustomizerTests.java
Outdated
Show resolved
Hide resolved
odrotbohm
force-pushed
the
hacking/spring-modulith
branch
from
728cbfc
to
758031e
Compare
|
That's been a useful tip, thanks! I have incorporated your feedback, fixed the Checkstyle issues and updated the branch. |
|
Unfortunately, the build is failing for me and I can still see a bunch of additional newlines in method bodies. Can you please look again? |
This commit adds support to add Spring Modulith to a project. We add the Event Publication Registry matching the (optionally) also selected persistence flavor (JPA, JDBC, MongoDB). Also, the observability support in case any of the supported observability backends is selected as dependency.
odrotbohm
force-pushed
the
hacking/spring-modulith
branch
from
758031e
to
5df35cf
Compare
|
Sorry, for the hassle. Done. |
snicoll
added
type: entry-proposal
and removed
type: enhancement
status: waiting-for-triage
|
I've taken over now so there's no need to push further updates. I've created spring-projects/spring-modulith#237 as the core starter doesn't bring the "core" spring boot starter, which breaks the metadata test when this PR is around. I've also found some lingering |
snicoll
pushed a commit
that referenced
this pull request
Jul 10, 2023
This commit adds support to add Spring Modulith to a project. We add the Event Publication Registry matching the (optionally) also selected persistence flavor (JPA, JDBC, MongoDB). Also, the observability support in case any of the supported observability backends is selected as dependency. See gh-1228
snicoll
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to add Spring Modulith to a project. We add the Event Publication Registry matching the (optionally) also selected persistence flavor (JPA, JDBC, MongoDB). Furthermore, the observability support in case any of the supported observability backends is selected as dependency.