Add Testcontainers Solace module when solace and testcontainers are selected #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected Testcontainers offers a solace module that can be used when both technologies are selected.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @eddumelendez but I'd like to add new features like this consistently with what we have already. I wonder if we could generate the cc @Mrc0113 |
snicoll
added
the
status: waiting-for-feedback
snicoll
changed the title
|
Ahem. I've just realized the auto-configuration on the other side needs to handle |
snicoll
changed the title
snicoll
added
type: enhancement
and removed
status: waiting-for-feedback
|
I've created SolaceProducts/solace-spring-boot#106 |
snicoll
pushed a commit
that referenced
this pull request
Jul 31, 2023
This commit adds the solace module for Testcontainers if Testcontainers and Solace are selected. Note that it does not add support for connection details as Solace does not implement them at the moment. See gh-1262
|
Looking forward to see the ServiceConnection support in Solace Spring Boot so it can be autogenerated in start.spring.io. Thanks for raising the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcontainers offers a solace module that can be used when
both technologies are selected.