Add Testcontainers GCloud module when GCP messaging and testcontainers are selected #1264
Conversation
…s are selected Testcontainers offers a GCloud module where `PubSubEmulatorContainer` can be found and be used for testing.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks again @eddumelendez. Looking at the website the module states:
Is there a reason why the PR constrains it to only gcp pub sub? At the very least, GCP support should also include it as it is a segway to configure the project with GCP. |
snicoll
added
the
status: waiting-for-feedback
Yeah, make sense now that I think about it. I tried to be specific because GCP Messaging is the one that explicitly can provide the Testcontainers class. However, if as user I know I'll use Datastore, Firestore or Spanner I can select GCP support and Testcontainers which will provide the dependency too and later I can add the proper starter. I can update the PR later today. |
spring-projects-issues
added
status: feedback-provided
|
PR updated. Now, if cloud-gcp is selected, testcontainers gcloud module is also added. BTW, there is already an issue in spring-cloud-gcp to support ServiceConnections. See GoogleCloudPlatform/spring-cloud-gcp#1780 |
Testcontainers offers a GCloud module where `PubSubEmulatorContainer` can be found and be used for testing. See gh-1264
Testcontainers offers a GCloud module where `PubSubEmulatorContainer` can be found and be used for testing. See gh-1264
snicoll
added
type: enhancement
and removed
status: waiting-for-triage
|
Thanks for the update @eddumelendez. I've polished the proposal to avoid adding the help link twice if both gcp and gcp-pub-sub are selected. |
Testcontainers offers a GCloud module where
PubSubEmulatorContainercan be found and be used for testing.