Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pulsar container #1291

Closed
wants to merge 3 commits into from

Conversation

eddumelendez
Copy link
Contributor

Recently, spring pulsar was integrated in spring boot with
ConnectionDetails and ServiceConnection.

Recently, spring pulsar was integrated in spring boot with
`ConnectionDetails` and `ServiceConnection`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2023
@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 8, 2023
@snicoll snicoll self-assigned this Sep 8, 2023
@snicoll
Copy link
Contributor

snicoll commented Sep 8, 2023

@eddumelendez did you try it? I am asking as Pulsar can't be selected with Spring Boot 3.2 at the moment. I'd like to make sure that both integrations actually work against a sample app.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Sep 8, 2023
@onobc
Copy link
Contributor

onobc commented Sep 8, 2023

I have a PR queued up @eddumelendez for this. It also includes support for the existing 30 and pulsar pre-qa. Do you mind if we use mine instead? I did not push it yet as I was waiting for the command support to be merged.

@eddumelendez
Copy link
Contributor Author

it's totally fine. I totally forgot adding the new starters. We can close this one in favor of yours @onobc

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 8, 2023
@snicoll snicoll removed their assignment Sep 8, 2023
@snicoll snicoll added status: superseded and removed status: feedback-provided Feedback has been provided labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants