Add optional 'command' to Docker compose service #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@onobc I am totally cool with adding a command option but both PRs don't have a description. What's the need here for this? |
snicoll
added
the
status: waiting-for-feedback
|
Chris and I discussed this a bit yesterday. It's for Pulsar which requires a custom command be used to launch it in standalone mode. It's to enable the equivalent of this code in Testcontainers' |
wilkinsona
reviewed
Sep 8, 2023
start-site/src/main/java/io/spring/start/site/container/DockerService.java
Outdated
Show resolved
Hide resolved
|
Thanks @wilkinsona. I guess this should answer this question then #1291 (comment) |
snicoll
added
type: enhancement
and removed
status: waiting-for-feedback
snicoll
pushed a commit
that referenced
this pull request
Sep 15, 2023
snicoll
added a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on spring-io/initializr#1461