Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Spring Pulsar with Spring Boot 3.2.x #1296

Closed
wants to merge 3 commits into from

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Sep 8, 2023

This code proposal updates the Spring Pulsar dependencies as follows:

  • Maintain the legacy (pre-GA) starters
  • Provide the Boot starters when using 3.2.0-SNAPSHOT (will be adjusted to M3 once it ships)
  • Provide Docker Compose and Testcontainers generation when using 3.2.x

INFO This is a based off of (and thus requires) #1294 I just chose to push them individually.

* Split the Pulsar dependencies into Boot30/31 and
  Boot32 variants
* Add DockerCompose and Testcontainers support
* Enhance the tests for Pulsar
@onobc onobc marked this pull request as draft September 8, 2023 20:02
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 8, 2023
@snicoll snicoll changed the title Update Spring Pulsar for Spring Boot 3.2.0 Enable Spring Pulsar with Spring Boot 3.2.x Sep 15, 2023
@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 15, 2023
@snicoll snicoll self-assigned this Sep 15, 2023
@snicoll
Copy link
Contributor

snicoll commented Sep 15, 2023

OK cool I've rebased and polished locally. We're ready for M3 next week. We can't have "holes" in compatibility range so I'll wait for 3.2 to catch up first.

@snicoll snicoll marked this pull request as ready for review September 15, 2023 15:55
snicoll pushed a commit that referenced this pull request Sep 21, 2023
* Split the Pulsar dependencies into Spring Boot 3.0.x/3.1.x and
  3.2.x variants
* Add DockerCompose and Testcontainers support
* Enhance the tests for Pulsar

See gh-1296
snicoll added a commit that referenced this pull request Sep 21, 2023
@snicoll snicoll closed this in 16754ae Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants