Add Pulsar Binder to Spring Cloud Stream #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the Spring Cloud Stream Pulsar binder dependency is automatically added when the user chooses Spring Boot >= 3.2.0-M3 and adds the Pulsar and Cloud Stream dependencies.
onobc
commented
Oct 21, 2023
| @@ -85,6 +89,19 @@ void springCloudStreamWithKafkaStreams(Version springBootVersion, Dependency tes | |||
| .hasDependenciesSize(5); | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @MethodSource("springCloudStreamWithPulsarArguments") | |||
There was a problem hiding this comment.
I am not super excited of screaming "...WithPulsar" here but the variations we are now trying to test are:
- Boot 2.7.x (the test binder deps differ across 2.x and 3.x)
- Boot 3.x (test test binder deps differ across 2.x and 3.x)
- Boot 3.2.0-M3++ (new binder was added here)
Because the Pulsar binder does not exist <=3.2.0-M3 we can simply add more args to the test params for boot32x as the behavior is additive (iow new binder dep).
There was a problem hiding this comment.
I am not a big fan of those either. I've polished to make it short for now. We can revisit those tests once we remove support for 2.x which is soon.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: enhancement
and removed
status: waiting-for-triage
snicoll
pushed a commit
that referenced
this pull request
Oct 23, 2023
This commit ensures the Spring Cloud Stream Pulsar binder dependency is automatically added when the user chooses Spring Boot >= 3.2.0-M3 and adds the Pulsar and Cloud Stream dependencies. See gh-1322
snicoll
added a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures the Spring Cloud Stream Pulsar binder dependency is automatically added when the user chooses Spring Boot >= 3.2.0-M3 and adds the Pulsar and Cloud Stream dependencies.
This was not an issue in the older Spring Pulsar
0.2.xoffering because the binder was contained in the Spring Pulsar repo. Now the binder has been moved into SCSt proper, the binder dependency must be added as well. I missed this detail in my original update to Pulsar/Boot32.