ONEUP-7762: Fix linting issues

spring-media · Jan 2, 2024 · f15fbe2 · f15fbe2
1 parent f4b0e6a
commit f15fbe2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/src/StickyObserver.test.ts b/src/StickyObserver.test.ts
@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import sinon from 'sinon';
+import * as Helper from './helper';
 import { Sticky, StickyObserver } from './StickyObserver';
 import {
   scrollTo,
@@ -10,7 +11,6 @@ import {
   triggerResizeEvent
 } from './test-helper';
 import { StickyHTMLElement, StickyState } from './types';
-import * as Helper from './helper';
 
 // Info:
 // The sticky element should be always normal even on scrolling

diff --git a/src/StickyObserver.ts b/src/StickyObserver.ts
@@ -3,6 +3,7 @@ import {
   addPlaceholder,
   addStickyClass,
   noop,
+  PageSize,
   position,
   recalculateOnNormalState,
   removeClass,
@@ -11,8 +12,7 @@ import {
   removeScrollEvent,
   removeStickyClass,
   toNumber,
-  toStyleClasses,
-  PageSize
+  toStyleClasses
 } from './helper';
 import * as Helper from './helper';
 import * as states from './states';
@@ -235,7 +235,7 @@ export class StickyObserver implements Sticky {
   }
 
   private onResize(element: StickyHTMLElement): void {
-    const windowDimensions = Helper.getPageSize();
+    const windowDimensions: PageSize = Helper.getPageSize();
 
     if (this.pageSize.equals(windowDimensions)) {
       return;

diff --git a/src/helper.ts b/src/helper.ts
@@ -1,6 +1,9 @@
 import { RectPosition, StickyHTMLElement, StickyState } from './types';
 
-export type WidthHeight = { width: number; height: number };
+export interface WidthHeight {
+  width: number;
+  height: number;
+}
 export type PageSize = WidthHeight & { equals: (other: WidthHeight) => boolean };
 
 export const position: (element: HTMLElement) => RectPosition = (element: HTMLElement): RectPosition => {
@@ -137,9 +140,12 @@ export const toStyleClasses: (value: string | undefined) => string[] = (value: s
 export function getPageSize(): PageSize {
   const width: number = document.documentElement.scrollWidth;
   const height: number = document.documentElement.scrollHeight;
-  const equals = (other: WidthHeight) => {
-    return width === other.width && height === other.height;
-  };
 
-  return { width, height, equals };
+  return {
+    width,
+    height,
+    equals: (other: WidthHeight): boolean => {
+      return width === other.width && height === other.height;
+    }
+  };
 }