Integrate parser from spring-rewrite-commons #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of resources as provided to the TestProjectContext is not guaranteed anymore, now that parsed resources are taken from filesystem
With the new parser .txt and foo resources in src/main/resources were represented as Quarks and allowed no (usual) access to their content
With the new parser .txt and foo resources in src/main/resources were represented as Quarks and allowed no (usual) access to their content
…rite (#950) * Add method to sync recipe run * Moved ProjectResourceSet related classes to sbm-support-rewrite * Add temp integration test * Use new ProjectResourceSetFactory * Use RewriteMigrationResultMerger
* Remove @component and declare using @bean * Add dependency to rewrite-java-17 * Add dependency to rewrite-migrate-java * Add delombok * Renamed HelperWithoutAGoodName * Enhance README * Moved Maven-related classes to the maven package * Add javadoc * Remove dead code * Remove ExecutionContext parameter * Renamed SbmMavenProject * Moved logic into ParserContext * Add MavenModuleParser * Cleanup pom
- Introduce `ParserParityTestHelper` which takes a dir and parses the given project with `RewriteMavenProjectParser` (comparing) and `RewritePropjectParser` (system under test). The parsing result is then compared using AssertJ's `usingRecursiveComparison` which verifies that all markers and their fields of both parsing results are equal proving that both parsers yield the same result. - Introduce ´TestProjectHelper` which helps set up test projects. - Fixes multiple bugs, e.g. calculation of the classpath. - Cleanups and refactorings
Add support for `~/.m2/settings.xml` and `~/.m2/settings-security.xml`. - `Maven SettingsInitializer` reads the settings with decrypted credentials and adds them to the `ExecutionContext` Maven when build files get parsed. - `PrivateArtifactRepositoryTest` tests the behavior e2e. - Add Maven-related Autoconfiguration and move some beans there - `MavenExecutionRequest` now has the path to `settings.xml` - Polishing
* Move Maven related classes into maven package * Organize imports * Merge ModuleParser into MavenModuleParser
- Updated IgnoredPatterns - Added support for more Rewrite recipes --------- Co-authored-by: Fabian Krüger <56278322+fabapp2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.