Parser parity test #984
Merged
Parser parity test #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check is part of the MAven build
fabapp2
added
type: bug
The dependency could not be resolved when running GH build
Dependencies were not downloaded by RewriteMavenProjectParser. Adding the repository definition solved the issue.
fabapp2
added a commit
that referenced
this pull request
Nov 3, 2023
- Introduce `ParserParityTestHelper` which takes a dir and parses the given project with `RewriteMavenProjectParser` (comparing) and `RewritePropjectParser` (system under test). The parsing result is then compared using AssertJ's `usingRecursiveComparison` which verifies that all markers and their fields of both parsing results are equal proving that both parsers yield the same result. - Introduce ´TestProjectHelper` which helps set up test projects. - Fixes multiple bugs, e.g. calculation of the classpath. - Cleanups and refactorings
fabapp2
added a commit
that referenced
this pull request
Nov 6, 2023
- Introduce `ParserParityTestHelper` which takes a dir and parses the given project with `RewriteMavenProjectParser` (comparing) and `RewritePropjectParser` (system under test). The parsing result is then compared using AssertJ's `usingRecursiveComparison` which verifies that all markers and their fields of both parsing results are equal proving that both parsers yield the same result. - Introduce ´TestProjectHelper` which helps set up test projects. - Fixes multiple bugs, e.g. calculation of the classpath. - Cleanups and refactorings
fabapp2
added a commit
that referenced
this pull request
Nov 9, 2023
- Introduce `ParserParityTestHelper` which takes a dir and parses the given project with `RewriteMavenProjectParser` (comparing) and `RewritePropjectParser` (system under test). The parsing result is then compared using AssertJ's `usingRecursiveComparison` which verifies that all markers and their fields of both parsing results are equal proving that both parsers yield the same result. - Introduce ´TestProjectHelper` which helps set up test projects. - Fixes multiple bugs, e.g. calculation of the classpath. - Cleanups and refactorings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParserParityTestHelperwhich takes a dir and parses the given project withRewriteMavenProjectParser(comparing) andRewritePropjectParser(system under test). The parsing result is then compared using AssertJ'susingRecursiveComparisonwhich verifies that all markers and their fields of both parsing results are equal proving that both parsers yield the same result.