Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: equals method to aggregation and aggregation ops #4693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add: equals method to aggregation and aggregation ops #4693

wants to merge 1 commit into from

Conversation

therealansh
Copy link

Closes #4692 , Sorry for being the impatient one 😬 but would love to contribute.

  • Aggregation
  • AggregationPipeline
  • AggregationOperations:
    • AddFieldsOperation
    • BasicAggregation
    • BucketAutoOperation
  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@therealansh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@therealansh Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2024
@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

Sorry for being the impatient one 😬 but would love to contribute.

Thanks a lot for your contribution, we're happy to welcome contributions, also from impatient ones 🤩

While at it, we have a couple more AggregationOperations. Care to extend the pull request by adding equals/hashCode methods to the remaining types as well? That would greatly improve the duration until we can merge your pull request.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2024
@therealansh
Copy link
Author

@mp911de was on it already, thats why added a checklist to the PR summary, will extend this PR to cover those as well
thanks 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregation/Aggregation Operations - equals() function is missing
4 participants
@therealansh @pivotal-cla @mp911de @spring-projects-issues