Fix missing query options when calling MongoTemplate#findAndModify #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sriram-1729
changed the title
|
Thank you @sriram-1729 for taking the time to create this PR. |
sriram-1729
commented
Sep 6, 2024
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java
Outdated
Show resolved
Hide resolved
|
Hello @christophstrobl! In case the method signature change is allowed, should I keep the changes minimal, or can I make further modifications to remove redundant arguments? |
christophstrobl
added
the
for: team-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward maxTimeMsec from
QuerytoFindOneAndUpdateOptions.Closes #4776