Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Single Query Conversion into two-step process #1586

Closed
Tracked by #1445
mp911de opened this issue Aug 15, 2023 · 0 comments
Closed
Tracked by #1445

Split Single Query Conversion into two-step process #1586

mp911de opened this issue Aug 15, 2023 · 0 comments
Assignees
@mp911de
Labels
in: single-query-loading Everything related to querying aggregates with a single select. type: enhancement A general enhancement
Milestone
3.2 M3 (2023.1.0)

Comments

@mp911de
Copy link
Member

mp911de commented Aug 15, 2023

Right now, AggregateResultSetExtractor handles ResultSet advancing and conversion into objects. We should decouple these two steps using RowDocumentExtractor to create RowDocuments and in a second step, apply conversion to materialize aggregates.

This decouples complexity and allows faster failures when enforcing expected result counts.
@mp911de mp911de added the in: single-query-loading Everything related to querying aggregates with a single select. label Aug 15, 2023
@mp911de mp911de mentioned this issue Aug 15, 2023
Open
12 tasks
@mp911de mp911de added the type: enhancement A general enhancement label Aug 15, 2023
@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
@mp911de mp911de reopened this Sep 6, 2023
@mp911de mp911de self-assigned this Sep 6, 2023
@mp911de mp911de mentioned this issue Sep 6, 2023
Closed
schauder added a commit that referenced this issue Sep 8, 2023
@schauder
Remove external column name prefixing for embedded entities.
f600442 
Original pull request #1604
See #1586
schauder added a commit that referenced this issue Sep 8, 2023
@schauder
Polishing.
4cf07be 
Original pull request #1604
See #1586
@mp911de mp911de added this to the 3.2 M3 (2023.1.0) milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: single-query-loading Everything related to querying aggregates with a single select. type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M3 (2023.1.0)
Development

Successfully merging a pull request may close this issue.

Split Single Query Conversion into two-step process spring-projects/spring-data-relational
1 participant
@mp911de