Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine JDBC integration tests #1620

Closed
mp911de opened this issue Sep 20, 2023 · 0 comments
Closed

Refine JDBC integration tests #1620

mp911de opened this issue Sep 20, 2023 · 0 comments
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Sep 20, 2023

JDBC integration tests repeatedly are annotated with

@ContextConfiguration
@Transactional
@ExtendWith(SpringExtension.class)

and other annotations. It is not obvious for which databases some tests run as the typical test infers its config from profiles. Some tests use @ActiveProfiles("hsql") while others resort to @EnabledIfSystemProperty(named = "spring.profiles.active", matches = "postgres").

It would be neat to extract the database type into an enum and use in most places conditions through annotations.
@mp911de mp911de added the type: task A general task label Sep 20, 2023
@mp911de mp911de linked a pull request Sep 20, 2023 that will close this issue
Refine JDBC integration tests #1621
Closed
@mp911de mp911de mentioned this issue Sep 20, 2023
Closed
schauder added a commit that referenced this issue Oct 10, 2023
@schauder
Adapt to new test infrastructure.
ddec3cc 
Originial pull request #1222
See #1220
See #1620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine JDBC integration tests spring-projects/spring-data-relational
1 participant
@mp911de