Support Single Query Loading for aggregates with more than one collection #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add some documentation as the support keeps growing on what we support and what we do not support. |
|
That section does exist. And I updated it with the last commit. Why is it that after 26 years of doing this, I still forget the documentation? |
A couple years ago, we were used to write the docs in post-RC1. We usually forgot about it, so we made it a habit to consider (and include) the documentation in every ticket. That's also what reviews are for. |
Add github references to tests. See #1446
Updated the documentation to reflect the changes in Single Query Loading support. See #1448
Simplify code, remove code that is commented out, extract methods, pass PersistentEntity as argument instead of creating instances that hold PersistentEntity as field to align the class lifecycle with its contextual usage.
Use a single instance as there is no entity-specific state attached to AggregateReader.
mp911de
force-pushed
the
issue/more-than-one-collection
branch
from
a3be262 to
efaebda
Compare
mp911de
added a commit
that referenced
this pull request
Sep 27, 2023
Remove Jetbrains annotation usage. Simplify code, remove code that is commented out, extract methods, pass PersistentEntity as argument instead of creating instances that hold PersistentEntity as field to align the class lifecycle with its contextual usage. Refactor AggregateReader lifecycle, use a single instance as there is no entity-specific state attached to AggregateReader. Add Javadoc. See #1448 Original pull request: #1622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does NOT included nested relationships
Closes #1448