Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema generation [DATAJDBC-536] #756

Closed
6 tasks done
spring-projects-issues opened this issue May 6, 2020 · 2 comments
Closed
6 tasks done

Schema generation [DATAJDBC-536] #756

spring-projects-issues opened this issue May 6, 2020 · 2 comments
Assignees
Labels

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented May 6, 2020

Using this issue as the epic to track implementing Schema Generation

Issues in epic:

Original comment in ticket

Mark Paluch opened DATAJDBC-536 and commented

We should investigate how we can generate a base-schema to be used with Spring Data JDBC. Schema generation should consider a simple approach without reflecting each database quirk. We should investigate whether we could integrate with tools like Liquibase and provide customization hooks so that applications can hook into the process and provide advanced schema definitions where needed


Issue Links:

  • DATAJDBC-537 Reduce need for script duplication when adding support for a new database type
@airoasis
Copy link

Any updates?

@kurtn718 kurtn718 self-assigned this Mar 30, 2023
@kurtn718
Copy link
Contributor

It seems like we would want something similar to this Liquibase project - in terms of functionality (initial schema generation and change sets)

https://github.com/liquibase/liquibase-hibernate

except that of course it would use Spring Data JDBC annotations as the source to Liquibase.

@mp911de mp911de closed this as completed in 5f4ef2f Jun 6, 2023
mp911de added a commit that referenced this issue Jun 6, 2023
Reformat code, switch to tabs. Accept property in DatabaseTypeMapping to provide more context to the type mapping component.

Rename LiquibaseChangeSetGenerator to …Writer as we're writing a changeset and computing the contents is a consequence of writing a changeset. Refine naming to express what we're actually doing.

Introduce setters for enhanced configuration of predicates. Reduce visibility of types to avoid unwanted public API where public access is not needed.

Remove usused code, move methods around for improved grouping of code.

Rename package to schema as the schema is being created and updated and not generated. Rename …Model classes to just their name as types are package-private and not visible externally. Refactor SchemaDiff to Java record.

Use different overloads to write schema changes to avoid LiquibaseException leaking into cases where no diff is being used. Introduce SchemaFilter to filter unwanted mapped entities.

Move code to JDBC module. Introduce comparator strategy to customize how table and column names are compared.

See #756
Original pull request: #1520
mp911de added a commit that referenced this issue Jun 6, 2023
See #756
Original pull request: #1520
mp911de added a commit that referenced this issue Jun 6, 2023
Reorder dependencies.

See #756
@mp911de mp911de added this to the 3.2 M1 (2023.1.0) milestone Jun 6, 2023
@mp911de mp911de linked a pull request Jun 6, 2023 that will close this issue
4 tasks
kobaeugenea added a commit to kobaeugenea/spring-data-relational that referenced this issue Sep 30, 2023
schauder pushed a commit that referenced this issue Oct 19, 2023
schauder pushed a commit that referenced this issue Nov 24, 2023
schauder added a commit that referenced this issue Nov 24, 2023
Removed tests for circular references since they are not supported by Spring Data Relational.

Closes #1599
See #756, #1600
Original pull request #1629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants