-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1828 aggregate ref with convertable #1829
base: main
Are you sure you want to change the base?
Conversation
It should be exactly one to apply Instead, we should be explicit that we work with a reference and apply domain-specific rules of the underlying entity. For the time being, we can adopt the fix to align with the remainder of conversion. However, we should refactor |
38d2e6b
to
08c1900
Compare
I rebased the PR with the intend to clean it up. But it turns out the solution collides with the resolution of #1842 |
This facilitates testing of Criteria construction and is also usful, when keeping Criteria instances in sets or similar. Closes #1960
Simplifying test code
08c1900
to
531171e
Compare
This resolves the issue at hand, but in an ad hoc way, which feels very wrong. I still feel like I/we are doing something wrong with these conversions.
The problem here is:
Given an
AggregateReference<E, C>
withE
an entity andC
a type for which a write converter is regsitered, we currently determineC
as the target type of the conversion.With this information we call the
AggregateReference
converter, which extracts the id value and determines it is done, because the result is of the desired target type.This is demonstrated by the failing new unit test.
The integration test is fixed by just slapping a
getPotentiallyConvertedSimpleWrite
on the already converted type, which looks exactly for the customconversions, that we currently missing.But this means we do 2 custom conversions. Why 2? Why not arbitrary many?