Provide more expressive exception for projections without properties. #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
changed the title
schauder
force-pushed
the
issue/1813-improve-error-message
branch
from
7039927
to
ae27e23
Compare
mp911de
reviewed
Sep 24, 2024
|
|
||
| String sql = SqlRenderer.create(renderContextFactory.createRenderContext()).render(select); | ||
|
|
||
| return new ParametrizedQuery(sql, parameterSource); | ||
| } | ||
|
|
||
| private Select getSelect(SelectBuilder.BuildSelect completedBuildSelect) { |
There was a problem hiding this comment.
Why is the selection list empty in the first place? I'd assume that we pass-thru ReturnedType.InputProperties without checking whether these are empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1813