Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and annotation use in reference documentation #2370

Closed
wants to merge 3 commits into from

Conversation

yejianfengblue
Copy link
Contributor

@yejianfengblue yejianfengblue commented Feb 17, 2024

  1. Change the url in important note to /scanners/search/producers, so as to match the mapping path in @GetMapping(path = "/scanners/search/producers")

  2. Change annotation @BasePathAwareController to @RepositoryRestController in the java code examples, because the text is talking about @RepositoryRestController.

  3. Change the header @RepositoryRestResource VS. @BasePathAwareController to @RepositoryRestController VS. @BasePathAwareController, because the content is talking about @RepositoryRestController

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

fix typo in the mapping path
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 17, 2024
`@RepositoryRestResource` VS. `@BasePathAwareController` is changed to `@RepositoryRestController` VS. `@BasePathAwareController`
@yejianfengblue yejianfengblue changed the title Update overriding-sdr-response-handlers.adoc Fix typo in overriding-sdr-response-handlers.adoc Feb 18, 2024
The text is talking about @RepositoryRestController but the java code uses @BasePathAwareController
@mp911de mp911de self-assigned this Mar 4, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 4, 2024
@mp911de mp911de changed the title Fix typo in overriding-sdr-response-handlers.adoc Fix typos and annotation use in reference documentation Mar 5, 2024
@mp911de mp911de added this to the 4.2.4 (2023.1.4) milestone Mar 5, 2024
mp911de pushed a commit that referenced this pull request Mar 5, 2024
mp911de added a commit that referenced this pull request Mar 5, 2024
Reformat code. Add missing this. prefix for field assignment.

See #2370
@mp911de mp911de closed this in 8d4cf6e Mar 5, 2024
mp911de added a commit that referenced this pull request Mar 5, 2024
Reformat code. Add missing this. prefix for field assignment.

See #2370
@mp911de
Copy link
Member

mp911de commented Mar 5, 2024

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants