Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument resolver for PersistentEntityResource invalidly asks converter whether they can deserialize PER #2419

Closed
odrotbohm opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
type: bug A general bug

Comments

@odrotbohm
Copy link
Member

In PersistentEntityResourceHandlerMethodArgumentResolver, we ask the downstream HttpMessageConverters whether they can read PersistentEntityResource. For Jackson-based converters, this will result in a call to ObjectMapper.canDeserialize(…) which apparently accidentally works on Jackson 2.17. On 2.18 the detection of the creator properties seems to have changed so that PER is (rightfully) rejected for deserialization. This now causes no converter being found and thus an HttpMessageNotReadableException being thrown.

We should switch to asking the converters whether they're able to read the actual domain type, as that's what we actually do in the subsequent call to read(…).

@odrotbohm odrotbohm added the type: bug A general bug label Oct 4, 2024
@odrotbohm odrotbohm added this to the 4.4 RC1 (2024.1.0) milestone Oct 4, 2024
@odrotbohm odrotbohm self-assigned this Oct 4, 2024
odrotbohm added a commit that referenced this issue Oct 4, 2024
odrotbohm added a commit that referenced this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant