Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support validation non PersistentEntity types #2252

Closed
wants to merge 1 commit into from

Conversation

f-cramer
Copy link
Contributor

@f-cramer f-cramer commented Apr 13, 2023

This change is required to perform validation on converted fields of JPA entities. Their types might not be managed types and as such no JPAPersistentEntity instances are created for them. Before these changes this would result in a NotReadablePropertyException every time there is a validation error in one of those fields.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@f-cramer
Copy link
Contributor Author

any chance to get this reviewed before the next release on friday?

@f-cramer
Copy link
Contributor Author

Is there anything more I can do to get this ready to be merged?

odrotbohm pushed a commit that referenced this pull request Mar 14, 2024
For entity types that use transient fields, the validation integration needs to treat those as normal bean types an must not reject the values right away.

Fixes GH-2252.
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
@odrotbohm odrotbohm closed this in bf17f39 Mar 14, 2024
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
odrotbohm pushed a commit that referenced this pull request Mar 14, 2024
For entity types that use transient fields, the validation integration needs to treat those as normal bean types an must not reject the values right away.

Fixes GH-2252.
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
@odrotbohm odrotbohm removed the status: waiting-for-triage An issue we've not yet triaged label Mar 14, 2024
@odrotbohm odrotbohm added this to the 4.1.10 (2023.0.10) milestone Mar 14, 2024
@odrotbohm odrotbohm changed the title Support Validation for fields the type of which is not a PersistentEntity Support validation non PersistentEntity types Mar 14, 2024
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
odrotbohm added a commit that referenced this pull request Mar 14, 2024
Related ticket: GH-2252.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants