Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unmapped wrapper the default #78

Open
hollsk opened this issue Nov 29, 2016 · 2 comments
Open

Make unmapped wrapper the default #78

hollsk opened this issue Nov 29, 2016 · 2 comments
Milestone

Comments

@hollsk
Copy link
Contributor

hollsk commented Nov 29, 2016

Currently the default wrapper is statsd, which contains a normalisation step. This makes things kind of confusing for people who just use the default mapper, who wonder why their data has vanished on the way through Boomcatch.

#58 was created to remove the normalisation from the existing mappers, but not from the default package - it would probably help to change the default mapper to unmapped instead, so users get a JSON serialisation of the Boomerang payload. This will give us some breathing space to rewrite the rest of the mappers ( #79 ).

@hollsk hollsk added this to the 4.0.0 milestone Nov 29, 2016
@hollsk
Copy link
Contributor Author

hollsk commented Feb 7, 2017

@philbooth do you think this proposal (changing the default mapper from statsd to unmapped ) is a horrible idea? It would obviously be a breaking change.

I've just done it locally and tweaked the tests but now I'm having a crisis of confidence. Save me, Phil!

@philbooth
Copy link
Contributor

OH HAI @hollsk!

Hrrm, I'm not sure if there is a definitive answer here, so probably just go with your gut.

As a rule of thumb, I think it's good for things to just work out of the box without any configuramisation needed. But whether works out of the box means "sends to statsd" or whether it means "shows me all the data", I'm not sure. Struggling to page in all the context tbh.

If the default mapper is unmapped, what would the default forwarder be? Will they work well as a pair?

Or maybe just try it and see what happens? Major version bumps === progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants