Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated Buffer constructor #94

Open
josebolos opened this issue Jun 14, 2018 · 0 comments
Open

Avoid using deprecated Buffer constructor #94

josebolos opened this issue Jun 14, 2018 · 0 comments
Milestone

Comments

@josebolos
Copy link
Contributor

new Buffer() has been marked as deprecated in Node.js 10 due to security concerns.

Running boomcatch with NODE_OPTIONS=--trace-warnings shows a deprecation notice in forwarders/udp.js.

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:159:11)
    at new Buffer (buffer.js:174:3)
    at sendToSocket (/Users/jose.bolos/devel/boomcatch/src/forwarders/udp.js:63:22)
    at send (/Users/jose.bolos/devel/boomcatch/src/forwarders/udp.js:55:16)
    at send (/Users/jose.bolos/devel/boomcatch/src/index.js:670:9)
    at IncomingMessage.emit (events.js:182:13)
    at endReadableNT (_stream_readable.js:1081:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

We probably want to fix this to ensure compatibility with future versions of node.js.

@josebolos josebolos added this to the 4.0.0 milestone Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant