CORE-1546: Send an email only on successful registration; Adjust phpd…

…oc for the customer facade
spryker · Jul 24, 2017 · 4e49b8e · 4e49b8e
1 parent f7ffe41
commit 4e49b8e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Spryker/Zed/Customer/Business/Customer/Customer.php b/src/Spryker/Zed/Customer/Business/Customer/Customer.php
@@ -187,7 +187,9 @@ public function register(CustomerTransfer $customerTransfer)
     {
         $customerResponseTransfer = $this->add($customerTransfer);
 
-        $this->sendRegistrationToken($customerTransfer);
+        if ($customerResponseTransfer->getIsSuccess()) {
+            $this->sendRegistrationToken($customerTransfer);
+        }
 
         return $customerResponseTransfer;
     }

diff --git a/src/Spryker/Zed/Customer/Business/CustomerFacade.php b/src/Spryker/Zed/Customer/Business/CustomerFacade.php
@@ -49,6 +49,8 @@ public function addCustomer(CustomerTransfer $customerTransfer)
     }
 
     /**
+     * {@inheritdoc}
+     *
      * @api
      *
      * @param \Generated\Shared\Transfer\CustomerTransfer $customerTransfer

diff --git a/src/Spryker/Zed/Customer/Business/CustomerFacadeInterface.php b/src/Spryker/Zed/Customer/Business/CustomerFacadeInterface.php
@@ -43,7 +43,7 @@ public function addCustomer(CustomerTransfer $customerTransfer);
      * Specification:
      * - Hashes password if provided
      * - Saves customer
-     * - Sends registration email if desired
+     * - Sends registration email (on successful registration)
      * - Returns CustomerResponseTransfer with success flag
      *
      * @api
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         /**
+         * {@inheritdoc}
+         *
          * @api
          *
          * @param \Generated\Shared\Transfer\CustomerTransfer $customerTransfer
@@ Expand Down @@