Skip to content

Commit

Permalink
CORE-783 Fixes according to review
Browse files Browse the repository at this point in the history
- Removed superfluous interfaces and entries in ProductDependencyProvider
- Added missing interfaces for business classes
- Fixed missing / wrong specifications and inherits
- Renamed ProductMetadata to ItemMetadata
- Used UtilEncodingService instead of json_encode
- Fix usage of missing twig file in order detail view
- Resolved some dependency issues
  • Loading branch information
lmanzke committed Jul 13, 2017
1 parent 4723ee5 commit f7ffe41
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ protected function getStore()
}

/**
* @return \Spryker\Zed\Customer\Business\Sales\CustomerOrderHydrator
* @return \Spryker\Zed\Customer\Business\Sales\CustomerOrderHydratorInterface
*/
public function createCustomerOrderHydrator()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Spryker/Zed/Customer/Business/CustomerFacade.php
Original file line number Diff line number Diff line change
Expand Up @@ -435,10 +435,10 @@ public function findByReference($customerReference)
}

/**
* @api
*
* {@inheritdoc}
*
* @api
*
* @param \Generated\Shared\Transfer\OrderTransfer $orderTransfer
*
* @return \Generated\Shared\Transfer\OrderTransfer
Expand Down
4 changes: 2 additions & 2 deletions src/Spryker/Zed/Customer/Business/CustomerFacadeInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ public function findByReference($customerReference);
* @api
*
* Specification
* - finds customer by reference
* - stores customer information on an order
* - Finds customer by reference
* - Hydrates the customer information into an order
*
* @param \Generated\Shared\Transfer\OrderTransfer $orderTransfer
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
use Generated\Shared\Transfer\OrderTransfer;
use Spryker\Zed\Customer\Business\Customer\CustomerInterface;

class CustomerOrderHydrator
class CustomerOrderHydrator implements CustomerOrderHydratorInterface
{

/**
* @var \Spryker\Zed\Customer\Business\Customer\CustomerInterface
*/
private $customer;
protected $customer;

/**
* @param \Spryker\Zed\Customer\Business\Customer\CustomerInterface $customer
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

/**
* Copyright © 2016-present Spryker Systems GmbH. All rights reserved.
* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
*/

namespace Spryker\Zed\Customer\Business\Sales;

use Generated\Shared\Transfer\OrderTransfer;

interface CustomerOrderHydratorInterface
{

/**
* @param \Generated\Shared\Transfer\OrderTransfer $orderTransfer
*
* @return \Generated\Shared\Transfer\OrderTransfer
*/
public function hydrateOrderTransfer(OrderTransfer $orderTransfer);

}

0 comments on commit f7ffe41

Please sign in to comment.