Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsecured terminal access #320

Open
izahn opened this issue Apr 19, 2022 · 2 comments
Open

Unsecured terminal access #320

izahn opened this issue Apr 19, 2022 · 2 comments

Comments

@izahn
Copy link

izahn commented Apr 19, 2022

Description of your problem

spyder-terminal runs an unsecured shell accessible to all users on the system, posing a huge security problem in multi-user environments.

What steps will reproduce the problem?

  1. Start spyder
  2. Use top or similar system monitor to identify the port that spyder_terminal.server is running on
  3. Open a web browser and navigate to localhost:<port> where <port> is the number identified in step 2

What is the expected output? What do you see instead?

I expect to see nothing, or at least be required to supply a password or token. Instead I immediately have full shell access through the web browser.

Please provide any additional information below

This might be OK on single-user systems, but in a HPC context where many users are logged in to the same computer it is a security disaster.

Versions and main components

  • Terminal Version: 1.2.2
  • Spyder Version: 5.3.0
  • Python Version: 3.9
  • Operating system: Linux
@izahn izahn changed the title Unsecurred terminal access Unsecured terminal access Apr 19, 2022
@ccordoba12
Copy link
Member

ccordoba12 commented Apr 22, 2022

Hey @izahn, thanks a lot for reporting this serious security problem, of which we were not fully aware. We discussed it with the team and concluded the fix is not simple.

However, we'll try to address it in the next couple of months due to its relevance.

@izahn
Copy link
Author

izahn commented Apr 22, 2022

Thanks guys, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants