Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #500, handle BETWEEN inside CASE expression #654

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix #500, handle BETWEEN inside CASE expression #654

merged 1 commit into from
Oct 31, 2023

Conversation

QoVoQ
Copy link

@QoVoQ QoVoQ commented Oct 31, 2023

fix #500

@QoVoQ
Copy link
Author

QoVoQ commented Oct 31, 2023

Hi, @nene could you help to review this PR at your convenience ? thx.

nene
nene approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@nene nene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. This looks great!

Fiddled around with this and it seems to work as expected.

I'll probably tweak this a bit (to avoid property_access_prefix being almost a duplicate of asteriskless_andless_expression but not quite).

Thanks again for tackling this long-standing bug.

@nene nene merged commit b4153e0 into sql-formatter-org:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nene nene nene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with BETWEEN inside CASE expression
2 participants
@QoVoQ @nene