use string for mysql bigint #16
Merged
+47
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshrsmz
commented
Feb 26, 2024
yshrsmz
force-pushed
the
string-bignumbers
branch
from
174c7bd to
2786a55
Compare
yshrsmz
force-pushed
the
string-bignumbers
branch
from
2786a55 to
d7474a6
Compare
yshrsmz
commented
Mar 3, 2024
There was a problem hiding this comment.
@kyleconroy I've updated the code to class-style driver. please take a look 🙏
| @@ -146,17 +147,15 @@ ${query.text}` | |||
| ) | |||
| ); | |||
|
|
|||
| const ctype = driver.columnType; | |||
There was a problem hiding this comment.
we could do
const ctype = driver.columnType.bind(driver)instead to preserve this in columnType(), but passing the driver directly is easier to understand.
kyleconroy
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #15