Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sqlfluff from 3.2.5 to 3.3.0 #414

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps sqlfluff from 3.2.5 to 3.3.0.

Release notes

Sourced from sqlfluff's releases.

[3.3.0] - 2024-12-10

Highlights

This release brings a few more significant changes. Especially given the introduction of several new rules, we highly recommend testing this release on your project before upgrading to make sure they are configured appropriately for your project style guide. As always, we have tried to make sure that the defaults for all new rules are both widely applicable, and fairly light touch. While all have been tested on some existing larger codebases which the maintainers have access to - do still report any bugs you might find on GitHub in the usual manner.

  • We've dropped the appdirs package as a dependency (as an abandoned project) and instead added platformdirs instead. Users should not notice any functionality changes beyond the different dependency.
  • TWO new dialects: Impala and StarRocks.
  • FIVE new rules:
    • AM08 (ambiguous.join_condition), which detects JOIN clauses without conditions (i.e. without an ON or USING clause). These are often typos and can result in significant row count increases if unintended.
    • CV12 (convention.join_condition), which is related to AM08 and detects cases where users have used a WHERE clause instead of a JOIN ... ON ... clause to do their join conditions. The join condition is a form of metadata and should communicate to the end user how the table should be joined. By mixing this information into the WHERE clause it makes the SQL harder to understand.
    • LT14 (layout.keyword_newline), which allows certain keywords to trigger line breaks in queries. Primarily this forces the main SELECT statement clauses like WHERE, GROUP BY etc. onto new lines. This rule has been designed to be highly configurable, but with sensible light-touch defaults. Check out the docs to adapt it to the conventions of your project.
    • ST10 (structure.constant_expression), some SQL users include redundant expressions in their code (e.g. WHERE tbl.col = tbl.col). These conditions always evaluate to a constant outcome (i.e. always evaluate as TRUE or FALSE) as so add no functionality or meaning to the query. This rule catches them.
    • ST11 (structure.unused_join), which detects unused joins in SQL statements, and is designed to catch tables that were once used, but where the column references have since been removed and now the table is unnecessary.

Beyond these changes, we've seen a whole host of dialect improvements to almost all of the supported dialects and several bugfixes which are combined into this release.

We also welcome TWELVE new contributors to the project in this release. Thanks to all of them for their hard work 🚀🏆🚀.

What’s Changed

... (truncated)

Changelog

Sourced from sqlfluff's changelog.

[3.3.0] - 2024-12-10

Highlights

This release brings a few more significant changes. Especially given the introduction of several new rules, we highly recommend testing this release on your project before upgrading to make sure they are configured appropriately for your project style guide. As always, we have tried to make sure that the defaults for all new rules are both widely applicable, and fairly light touch. While all have been tested on some existing larger codebases which the maintainers have access to - do still report any bugs you might find on GitHub in the usual manner.

  • We've dropped the appdirs package as a dependency (as an abandoned project) and instead added platformdirs instead. Users should not notice any functionality changes beyond the different dependency.
  • TWO new dialects: Impala and StarRocks.
  • FIVE new rules:
    • AM08 (ambiguous.join_condition), which detects JOIN clauses without conditions (i.e. without an ON or USING clause). These are often typos and can result in significant row count increases if unintended.
    • CV12 (convention.join_condition), which is related to AM08 and detects cases where users have used a WHERE clause instead of a JOIN ... ON ... clause to do their join conditions. The join condition is a form of metadata and should communicate to the end user how the table should be joined. By mixing this information into the WHERE clause it makes the SQL harder to understand.
    • LT14 (layout.keyword_newline), which allows certain keywords to trigger line breaks in queries. Primarily this forces the main SELECT statement clauses like WHERE, GROUP BY etc. onto new lines. This rule has been designed to be highly configurable, but with sensible light-touch defaults. Check out the docs to adapt it to the conventions of your project.
    • ST10 (structure.constant_expression), some SQL users include redundant expressions in their code (e.g. WHERE tbl.col = tbl.col). These conditions always evaluate to a constant outcome (i.e. always evaluate as TRUE or FALSE) as so add no functionality or meaning to the query. This rule catches them.
    • ST11 (structure.unused_join), which detects unused joins in SQL statements, and is designed to catch tables that were once used, but where the column references have since been removed and now the table is unnecessary.

Beyond these changes, we've seen a whole host of dialect improvements to almost all of the supported dialects and several bugfixes which are combined into this release.

We also welcome TWELVE new contributors to the project in this release. Thanks to all of them for their hard work 🚀🏆🚀.

What’s Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sqlfluff](https://github.com/sqlfluff/sqlfluff) from 3.2.5 to 3.3.0.
- [Release notes](https://github.com/sqlfluff/sqlfluff/releases)
- [Changelog](https://github.com/sqlfluff/sqlfluff/blob/main/CHANGELOG.md)
- [Commits](sqlfluff/sqlfluff@3.2.5...3.3.0)

---
updated-dependencies:
- dependency-name: sqlfluff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Dec 16, 2024
@nolanbconaway nolanbconaway merged commit d7a0736 into master Dec 16, 2024
1 check passed
@nolanbconaway nolanbconaway deleted the dependabot/pip/sqlfluff-3.3.0 branch December 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant