Filtered highlight errors in log stores to only recent errors #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The highlighted errors can often contain red herrings in the form of old errors that aren't relevant to the issue that was seen just prior to filing the bug report. While some errors can have downstream effects much later, I've found that more often than not an older error message is unrelated and simply adds noise. This filters out error messages that are older than 1 hour from the highlighted errors. The time interval is configurable, so developers can adjust as appropriate for their app's behavior.
sethfri
approved these changes
Sep 23, 2021
I'm fine with 30 minutes as the default. 👍 |
NickEntin
force-pushed
the
entin/highlights-summary
branch
3 times, most recently
from
67020d5
to
ea60180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlighted errors can often contain red herrings in the form of old errors that aren't relevant to the issue that was seen just prior to filing the bug report. While some errors can have downstream effects much later, I've found that more often than not an older error message is unrelated and simply adds noise.
This filters out error messages that are older than 1 hour from the highlighted errors. The time interval is configurable, so developers can adjust as appropriate for their app's behavior.