feat: localization

squidrye · Sep 22, 2023 · 42548d9 · 42548d9
1 parent 58b0a06
commit 42548d9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 31 deletions.
diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_action_type.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_action_type.dart
@@ -14,8 +14,6 @@ enum ViewMoreActionType {
   openInNewTab,
   splitRight,
   splitDown,
-  splitUp,
-  splitLeft,
 }
 
 extension ViewMoreActionTypeExtension on ViewMoreActionType {
@@ -38,13 +36,9 @@ extension ViewMoreActionTypeExtension on ViewMoreActionType {
       case ViewMoreActionType.openInNewTab:
         return LocaleKeys.disclosureAction_openNewTab.tr();
       case ViewMoreActionType.splitDown:
-        return 'Split Down';
+        return LocaleKeys.disclosureAction_splitDown.tr();
       case ViewMoreActionType.splitRight:
-        return 'Split Right';
-      case ViewMoreActionType.splitLeft:
-        return 'Split Left';
-      case ViewMoreActionType.splitUp:
-        return 'Split Up';
+        return LocaleKeys.disclosureAction_splitRight.tr();
     }
   }
 
@@ -68,13 +62,9 @@ extension ViewMoreActionTypeExtension on ViewMoreActionType {
         return const FlowySvg(FlowySvgs.full_view_s);
 
       case ViewMoreActionType.splitDown:
-        return const Icon(Icons.horizontal_split);
+        return const Icon(Icons.horizontal_split, size: 20);
       case ViewMoreActionType.splitRight:
-        return const Icon(Icons.vertical_split);
-      case ViewMoreActionType.splitUp:
-        return const Icon(Icons.horizontal_split);
-      case ViewMoreActionType.splitLeft:
-        return const Icon(Icons.vertical_split);
+        return const Icon(Icons.vertical_split, size: 20);
     }
   }
 }
diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart
@@ -423,18 +423,6 @@ class _SingleInnerViewItemState extends State<SingleInnerViewItem> {
                     plugin: widget.view.plugin(),
                     splitDirection: SplitDirection.right,
                   );
-
-            case ViewMoreActionType.splitLeft:
-              context.read<PanesCubit>().split(
-                    plugin: widget.view.plugin(),
-                    splitDirection: SplitDirection.left,
-                  );
-
-            case ViewMoreActionType.splitUp:
-              context.read<PanesCubit>().split(
-                    plugin: widget.view.plugin(),
-                    splitDirection: SplitDirection.up,
-                  );
             default:
               throw UnsupportedError('$action is not supported');
           }

diff --git a/...d/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart b/...d/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart
@@ -32,8 +32,6 @@ class ViewMoreActionButton extends StatelessWidget {
           : ViewMoreActionType.favorite,
       ViewMoreActionType.splitDown,
       ViewMoreActionType.splitRight,
-      ViewMoreActionType.splitLeft,
-      ViewMoreActionType.splitUp,
     ];
     return PopoverActionList<ViewMoreActionTypeWrapper>(
       direction: PopoverDirection.bottomWithCenterAligned,

diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart
@@ -1,6 +1,6 @@
 import 'package:appflowy/generated/flowy_svgs.g.dart';
 import 'package:appflowy/workspace/application/panes/panes.dart';
-import 'package:appflowy/workspace/application/tabs/tabs.dart';
+import 'package:appflowy/workspace/application/tabs/tabs_controller.dart';
 import 'package:appflowy/workspace/presentation/home/home_sizes.dart';
 import 'package:appflowy/workspace/presentation/home/home_stack.dart';
 import 'package:flowy_infra/theme_extension.dart';
@@ -87,6 +87,6 @@ class _FlowyTabState extends State<FlowyTab> {
   }
 
   void _closeTab([TapUpDetails? details]) =>
-      Provider.of<Tabs>(context, listen: false)
+      Provider.of<TabsController>(context, listen: false)
           .closeView(widget.pageManager.plugin.id);
 }
diff --git a/frontend/resources/translations/en.json b/frontend/resources/translations/en.json
@@ -87,14 +87,19 @@
     "openNewTab": "Open in a new tab",
     "moveTo": "Move to",
     "addToFavorites": "Add to Favorites",
-    "copyLink": "Copy Link"
+    "copyLink": "Copy Link",
+    "splitDown": "Split Down",
+    "splitRight": "Split Right",
+    "splitLeft": "Split Left",
+    "splitUp": "Split Up"
   },
   "blankPageTitle": "Blank page",
   "newPageText": "New page",
   "newDocumentText": "New document",
   "newGridText": "New grid",
   "newCalendarText": "New calendar",
   "newBoardText": "New board",
+  "readOnlyViewText":"Read only view",
   "trash": {
     "text": "Trash",
     "restoreAll": "Restore All",