From 9fd192f3bddc92462563a35db7ca4d6f74b6ae17 Mon Sep 17 00:00:00 2001 From: squidrye Date: Tue, 10 Oct 2023 20:45:25 +0530 Subject: [PATCH] chore: rename symbol --- .../lib/workspace/presentation/home/home_sizes.dart | 4 ++-- .../presentation/home/panes/draggable_pane_target.dart | 4 ++-- .../lib/workspace/presentation/home/panes/flowy_pane.dart | 1 - .../lib/workspace/presentation/home/tabs/flowy_tab.dart | 4 ++-- .../lib/workspace/presentation/home/tabs/tabs_manager.dart | 5 ++--- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart index 66cbd9ee5a65..1e6265d9c199 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart @@ -3,8 +3,8 @@ class HomeSizes { static const double topBarHeight = 60; static const double editPanelTopBarHeight = 60; static const double editPanelWidth = 400; - static const double tabBarHeigth = 40; - static const double tabBarWidth = 200; + static const double tabBarHeight = 40; + static const double tabWidth = 200; static const double resizeBarThickness = 2; } diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/draggable_pane_target.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/draggable_pane_target.dart index 2148251542ce..6f42abf6a54e 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/draggable_pane_target.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/draggable_pane_target.dart @@ -98,7 +98,7 @@ class _DraggablePaneTargetState extends State { double? left, top, height, width; final topOffset = (widget.pane.draggable as PaneNode).tabs.pages > 1 - ? HomeSizes.tabBarHeigth + HomeSizes.topBarHeight + ? HomeSizes.tabBarHeight + HomeSizes.topBarHeight : HomeSizes.topBarHeight; switch (position) { @@ -145,7 +145,7 @@ class _DraggablePaneTargetState extends State { CrossDraggableType type, ) { final top = (widget.pane.draggable as PaneNode).tabs.pages > 1 - ? HomeSizes.tabBarHeigth + HomeSizes.topBarHeight + ? HomeSizes.tabBarHeight + HomeSizes.topBarHeight : HomeSizes.topBarHeight; if (offset.dy <= top) { diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/flowy_pane.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/flowy_pane.dart index 0a760a70e598..ac47a6d64730 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/flowy_pane.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/panes/flowy_pane.dart @@ -39,7 +39,6 @@ class _FlowyPaneState extends State { @override Widget build(BuildContext context) { return ChangeNotifierProvider( - key: ValueKey(widget.node.tabs.tabId), create: (context) => widget.node.tabs, child: Consumer( builder: (context, value, __) { diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart index 80be2fa25c3e..6ab486255f50 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart @@ -35,8 +35,8 @@ class _FlowyTabState extends State { onEnter: (_) => _setHovering(true), onExit: (_) => _setHovering(), child: Container( - width: HomeSizes.tabBarWidth, - height: HomeSizes.tabBarHeigth, + width: HomeSizes.tabWidth, + height: HomeSizes.tabBarHeight, decoration: BoxDecoration( color: _getBackgroundColor(), ), diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/tabs_manager.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/tabs_manager.dart index 6612d5730456..8406c575f22d 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/tabs_manager.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/tabs_manager.dart @@ -66,7 +66,7 @@ class _TabsManagerState extends State } return Container( alignment: Alignment.bottomLeft, - height: HomeSizes.tabBarHeigth, + height: HomeSizes.tabBarHeight, decoration: BoxDecoration( color: Theme.of(context).colorScheme.surfaceVariant, ), @@ -87,9 +87,8 @@ class _TabsManagerState extends State tabs: widget.tabs.pageManagers .map( (pm) => SizedBox( + width: HomeSizes.tabWidth, key: ValueKey(pm.plugin.id), - width: HomeSizes.tabBarWidth, - height: HomeSizes.tabBarHeigth, child: DraggableTabItem( tabs: widget.tabs, pageManager: pm,