removed SafeMath #17
Open
removed SafeMath #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why are we removing safeMath? |
solidity 8.0^ has overflow protection built in. so its not necessary. |
|
Oh yeah, didn't even look at the pragma version, thank you. |
codenamejason
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated readme .md and dextemplate.sol to remove safemath, which is not necessary as of solidity 8.0
corrected the cd after git clone to point at correct folder
added a second "extra challenge" to checkpoint 6 to make the approval generated when the deposit button is pushed always approve the correct number of tokens