Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CONFIG_BROKER env var instead of CONFIG_BROKER_URL to be consistent with other projects, like Borges #168

Open
ajnavarro opened this issue Sep 29, 2017 · 4 comments

Comments

@ajnavarro
Copy link
Contributor

No description provided.

@erizocosmico
Copy link
Contributor

erizocosmico commented Sep 29, 2017

Doesn't the broker come from core? How is it possible it has different env vars?

@ajnavarro
Copy link
Contributor Author

I think because rovers is older than core-retrieval, and we implemented all the Rabbit stuff on rovers itself before the creation of core-retrieval.

@erizocosmico
Copy link
Contributor

Indeed: https://github.com/src-d/rovers/blob/master/core/config.go#L12

Then we should not only change the env var but change all that to use the actual core.

@smola
Copy link
Contributor

smola commented May 21, 2018

Note that we will probably favor CONFIG_BROKER_URI style instead of CONFIG_BROKER for variables describing a service with a URI: src-d/guide#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants