Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update engine and dependencies #363

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

affeldt28
Copy link
Contributor

Pull request template

Type of changes

Update all node16 to node20. Use .nvmrc for easier maintenance of workflows node version.

  • CI
  • Bugfix
  • Feature
  • Generic maintenance tasks
  • Documentation content changes
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no URL changes)
  • Improving performance of the project (not introducing new features)
  • Other (please describe):

Resolve Issue Number: #309 #362

What is the current behavior?

uses Node 16

What is the new behavior?

use Node 20

Does this introduce a breaking change?

  • Yes
  • No

It's considered a breaking change, because of the node version change. But this doesn't affect this action.

Other information

N/A

@github-actions github-actions bot added the ci 🤖 Work that improves the continuous integration. label Jul 21, 2024
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale 👻 No activity for quite some time. label Aug 21, 2024
@affeldt28
Copy link
Contributor Author

@srealmoreno could you please merge this?

@srealmoreno srealmoreno self-requested a review August 21, 2024 06:04
@srealmoreno srealmoreno added maintenance 📈 Generic maintenance tasks. enhancement ✨ Enhancement of the code, not introducing new features. dependencies 📦 Pull requests that update a dependency file. breaking-change 💥 A change that changes the API or breaks backward compatibility for users. and removed ci 🤖 Work that improves the continuous integration. stale 👻 No activity for quite some time. labels Aug 21, 2024
Copy link
Owner

@srealmoreno srealmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @affeldt28

Sorry for late, I was away for a while.

I will take an integration test and a test e2e and will merge this pr.

In addition to updating my dependencies.

For future pr please add me for reviewers.

Thanks 😃

@srealmoreno srealmoreno added enhancement ✨ Enhancement of the code, not introducing new features. breaking-change 💥 A change that changes the API or breaks backward compatibility for users. and removed enhancement ✨ Enhancement of the code, not introducing new features. dependencies 📦 Pull requests that update a dependency file. breaking-change 💥 A change that changes the API or breaks backward compatibility for users. maintenance 📈 Generic maintenance tasks. labels Aug 21, 2024
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale 👻 No activity for quite some time. label Sep 21, 2024
@affeldt28
Copy link
Contributor Author

Not Stale

@github-actions github-actions bot removed the stale 👻 No activity for quite some time. label Sep 24, 2024
@srealmoreno srealmoreno changed the base branch from main to maintenance September 27, 2024 16:32
srealmoreno
srealmoreno previously approved these changes Sep 27, 2024
@github-actions github-actions bot added the ci 🤖 Work that improves the continuous integration. label Sep 27, 2024
@srealmoreno srealmoreno changed the title Bump node version to v20 ⬆️ Update engine and dependencies Sep 27, 2024
@srealmoreno srealmoreno changed the base branch from maintenance to main September 27, 2024 16:52
@srealmoreno srealmoreno dismissed their stale review September 27, 2024 16:52

The base branch was changed.

@github-actions github-actions bot added the documentation 📝 Solely about the documentation of the project. label Sep 27, 2024
@github-actions github-actions bot added the maintenance 📈 Generic maintenance tasks. label Sep 27, 2024
srealmoreno
srealmoreno previously approved these changes Sep 27, 2024
@srealmoreno srealmoreno merged commit 850ba5c into srealmoreno:main Sep 27, 2024
10 checks passed
@srealmoreno srealmoreno modified the milestone: 362 Sep 27, 2024
@affeldt28 affeldt28 deleted the node-20 branch September 29, 2024 14:11
Copy link

github-actions bot commented Oct 8, 2024

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change 💥 A change that changes the API or breaks backward compatibility for users. ci 🤖 Work that improves the continuous integration. documentation 📝 Solely about the documentation of the project. enhancement ✨ Enhancement of the code, not introducing new features. maintenance 📈 Generic maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: NodeJS 16 actions are deprecated forced to use Node 20 [bug]: NodeJS 16 actions are deprecated
2 participants