Skip to content

Commit

Permalink
Confusion about File.separatorChar() causes failure to load .eea on w…
Browse files Browse the repository at this point in the history
…indows

fixes issue eclipse-jdt#1452:

defensively cope with separator mix, explicitly convert to File.separatorChar for directoryList, which performs actual
file I/O.
  • Loading branch information
stephan-herrmann authored Oct 1, 2023
1 parent d87b6f7 commit a0106eb
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ public class ClasspathDirectory extends ClasspathLocation {
this.encoding = encoding;
}
String[] directoryList(String qualifiedPackageName) {
if (File.separatorChar != '/' && qualifiedPackageName.indexOf('/') != -1) {
qualifiedPackageName = qualifiedPackageName.replace('/', File.separatorChar);
}
String[] dirList = (String[]) this.directoryCache.get(qualifiedPackageName);
if (dirList == this.missingPackageHolder) return null; // package exists in another classpath directory or jar
if (dirList != null) return dirList;
Expand Down

0 comments on commit a0106eb

Please sign in to comment.