Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Commit

Permalink
Merge pull request #47 from srinandan/nov8
Browse files Browse the repository at this point in the history
improve docs for cmds
  • Loading branch information
srinandan authored Nov 8, 2022
2 parents 0f40c15 + 0fa866c commit 16a9dd3
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmd/connectors/setadmin.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func init() {
SetAdminCmd.Flags().StringVarP(&memberName, "member", "m",
"", "Member Name, example Service Account Name")
SetAdminCmd.Flags().StringVarP(&memberType, "memberType", "p",
"serviceAccount", "memberType must be serviceAccount, user or group")
"serviceAccount", "memberType must be serviceAccount, user, or group (default serviceAccount)")

_ = SetAdminCmd.MarkFlagRequired("name")
}
2 changes: 1 addition & 1 deletion cmd/connectors/setcustom.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func init() {
SetCustomCmd.Flags().StringVarP(&role, "role", "r",
"", "Custom IAM role in the format projects/{project-id}/roles/{role}")
SetCustomCmd.Flags().StringVarP(&memberType, "memberType", "p",
"serviceAccount", "memberType must be serviceAccount, user or group")
"serviceAccount", "memberType must be serviceAccount, user, or group (default serviceAccount)")

_ = SetCustomCmd.MarkFlagRequired("name")
_ = SetCustomCmd.MarkFlagRequired("role")
Expand Down
4 changes: 2 additions & 2 deletions cmd/connectors/setinvoke.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

// SetInvokeCmd to set admin role
var SetInvokeCmd = &cobra.Command{
Use: "setadmin",
Use: "setinvoke",
Short: "Set Connection Invoke IAM policy on a Connection",
Long: "Set Connection Invoke IAM policy on a Connection",
Args: func(cmd *cobra.Command, args []string) (err error) {
Expand All @@ -41,7 +41,7 @@ func init() {
SetInvokeCmd.Flags().StringVarP(&memberName, "member", "m",
"", "Member Name, example Service Account Name")
SetInvokeCmd.Flags().StringVarP(&memberType, "memberType", "p",
"serviceAccount", "memberType must be serviceAccount, user or group")
"serviceAccount", "memberType must be serviceAccount, user, or group (default serviceAccount)")

_ = SetInvokeCmd.MarkFlagRequired("name")
}
4 changes: 2 additions & 2 deletions cmd/connectors/setviewer.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

// SetViewerCmd to set viewer role
var SetViewerCmd = &cobra.Command{
Use: "setadmin",
Use: "setviewer",
Short: "Set Connection Viewer IAM policy on a Connection",
Long: "Set Connection Viewer IAM policy on a Connection",
Args: func(cmd *cobra.Command, args []string) (err error) {
Expand All @@ -41,7 +41,7 @@ func init() {
SetViewerCmd.Flags().StringVarP(&memberName, "member", "m",
"", "Member Name, example Service Account Name")
SetViewerCmd.Flags().StringVarP(&memberType, "memberType", "p",
"serviceAccount", "memberType must be serviceAccount, user or group")
"serviceAccount", "memberType must be serviceAccount, user, or group (default serviceAccount)")

_ = SetViewerCmd.MarkFlagRequired("name")
}
3 changes: 2 additions & 1 deletion cmd/integrations/execute.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ func init() {
ExecuteCmd.Flags().StringVarP(&name, "name", "n",
"", "Integration flow name")
ExecuteCmd.Flags().StringVarP(&executionFile, "file", "f",
"", "Integration flow JSON file path")
"", "Integration payload JSON file path. For the payload structure, visit docs at"+
" https://cloud.google.com/application-integration/docs/reference/rest/v1/projects.locations.integrations/execute#request-body")

_ = ExecuteCmd.MarkFlagRequired("name")
_ = ExecuteCmd.MarkFlagRequired("file")
Expand Down

0 comments on commit 16a9dd3

Please sign in to comment.