Store information about NodeGeneration in registry. #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have, by the way, taken over the actual view on which nodes are eligable for topology generation. |
|
takes also already vr-vsrx into account. |
So far generate.go contained two lists indenpendent from the nodes, that would describe nodes that (1) can be generated and (b) what the interface naming convention would be for the node kind. This will introduce seperate fields in the NodeRegistry for this information, such that the information for this sort of node generation can be defined as part of the node definition
hellt
force-pushed
the
refactorgenerate
branch
from
dc33e4a to
8a32cb8
Compare
hellt
reviewed
Dec 5, 2024
hellt
reviewed
Dec 5, 2024
hellt
reviewed
Dec 5, 2024
| } | ||
|
|
||
| type GenerateNodeAttributes struct { | ||
| generateable bool |
There was a problem hiding this comment.
likely we don't need the generatable flag at all. All nodes should be generatable, I think some nodes were not generatable originally because we just did not add them manually to the generate cmd
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 51.54% 51.76% +0.21%
==========================================
Files 172 172
Lines 16888 16978 +90
==========================================
+ Hits 8705 8788 +83
- Misses 7259 7267 +8
+ Partials 924 923 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far generate.go contained two lists indenpendent from the nodes, that would describe nodes that (1) can be generated and (b) what the interface naming convention would be for the node kind. This will introduce seperate fields in the NodeRegistry for this information, such that the information for this sort of node generation can be defined as part of the node definition