Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build dynamic interface name map #2329

Merged
merged 3 commits into from
Dec 4, 2024
Merged

build dynamic interface name map #2329

merged 3 commits into from
Dec 4, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Dec 4, 2024

fix #2328

@hellt hellt marked this pull request as ready for review December 4, 2024 18:37
@hellt hellt merged commit 51c6366 into main Dec 4, 2024
67 checks passed
@hellt hellt deleted the gix-generate-vjunos branch December 4, 2024 19:20
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 81.53846% with 12 lines in your changes missing coverage. Please review.

Project coverage is 51.54%. Comparing base (1c068f9) to head (866110d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nodes/crpd/crpd.go 0.00% 0 Missing and 1 partial ⚠️
nodes/rare/rare.go 0.00% 0 Missing and 1 partial ⚠️
nodes/sonic/sonic.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_sros/vr-sros.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_veos/vr-veos.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_vjunosevolved/vr-vjunosevolved.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_vjunosswitch/vr-vjunosswitch.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_vmx/vr-vmx.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_vqfx/vr-vqfx.go 0.00% 0 Missing and 1 partial ⚠️
nodes/vr_vsrx/vr-vsrx.go 0.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
+ Coverage   51.36%   51.54%   +0.17%     
==========================================
  Files         172      172              
  Lines       16838    16888      +50     
==========================================
+ Hits         8649     8705      +56     
+ Misses       7264     7259       -5     
+ Partials      925      924       -1     
Files with missing lines Coverage Δ
cmd/generate.go 71.79% <100.00%> (+6.32%) ⬆️
links/link.go 63.15% <ø> (ø)
nodes/ceos/ceos.go 60.10% <100.00%> (ø)
nodes/crpd/crpd.go 0.86% <0.00%> (ø)
nodes/rare/rare.go 3.33% <0.00%> (ø)
nodes/sonic/sonic.go 2.85% <0.00%> (ø)
nodes/vr_sros/vr-sros.go 0.48% <0.00%> (ø)
nodes/vr_veos/vr-veos.go 1.75% <0.00%> (ø)
nodes/vr_vjunosevolved/vr-vjunosevolved.go 1.78% <0.00%> (ø)
nodes/vr_vjunosswitch/vr-vjunosswitch.go 1.78% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@steiler
Copy link
Collaborator

steiler commented Dec 5, 2024

@hellt I'm trying to get rid of these Funktions that sit somewhere that now need to have a notion of all the kinds that do exist... That's bad practice... You should delegate these calls to the kinds or make them register these informations in a register... But not these central functions see e.g. #1347 where by the way the interface name stuff was moved to the kinds... Maybe consider a refresh of that pr

@hellt
Copy link
Member Author

hellt commented Dec 5, 2024

good reminder. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerlab generate command not rendering link properly for juniper kind
2 participants