Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip binds path check option for destroy operation #2334

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Dec 6, 2024

fix #2298

@hellt hellt merged commit c25b2f4 into main Dec 6, 2024
66 of 67 checks passed
@hellt hellt deleted the skip-binds-check branch December 6, 2024 18:34
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (ca7e450) to head (aa6fb91).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
- Coverage   51.84%   51.82%   -0.03%     
==========================================
  Files         172      172              
  Lines       16978    16987       +9     
==========================================
  Hits         8803     8803              
- Misses       7256     7262       +6     
- Partials      919      922       +3     
Files with missing lines Coverage Δ
clab/clab.go 69.83% <100.00%> (-0.14%) ⬇️
cmd/destroy.go 77.18% <100.00%> (+0.46%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup fails when bind files are no longer available
1 participant