Mobile-friendly competiiton pages #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This visually rearranges it to be a bit like the docs nav on mobile, which changes from a sidebar to a collapsed stack at the top of the document.
PeterJCLaw
force-pushed
the
better-mobile-support
branch
from
631b5d3
to
f5d1894
Compare
This also generalises and improves how these are positioned and the margins assigned to them.
|
Oops, didn't meant to close this. |
I've had a quick go at this. I think there's still a lot more which could be done (mostly by reworking to use e.g: flexbox rather than floats & absolute position munging), but that's definitely more than I have time for. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to enable use of these pages on smaller screens. Suggest review by commit.
Nav adjusts a bit like the docs sidebar does:
Team/match choosers get dynamic wrapping:
Youtube embed on the homepage is responsive:
The rest of the homepage is left as-is. While we probably could do more with the various bits, that's likely to need deeper surgery than I have time for right now.
Builds on #52 for ease.