Skip to content

Commit

Permalink
Use a consistent mechanism to upload our reference build
Browse files Browse the repository at this point in the history
Something changed recently in how actions/upload-artifact creates
its archives, such that symlinked files behaved differently under
that action than under actions/upload-pages-artifact. This broke
our diffing logic.

Move to using the same upload approach for both the local and
reference main builds, to avoid spurious errors.
  • Loading branch information
PeterJCLaw committed Aug 3, 2024
1 parent 51fc880 commit b531856
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,10 @@ jobs:
- name: Build
run: rake build

- name: Upload build site
uses: actions/upload-artifact@v4
- name: Upload reference artifact
uses: actions/upload-pages-artifact@v3
with:
name: build-from-main
path: _site

diff:
runs-on: ubuntu-latest
Expand All @@ -113,7 +112,14 @@ jobs:
uses: actions/download-artifact@v4
with:
name: build-from-main
path: main

- name: Unpack main build
run: |
mkdir main
pushd main
tar --extract --file ../artifact.tar
popd
mv artifact.tar main.tar
- name: Diff
id: diff
Expand Down

0 comments on commit b531856

Please sign in to comment.