Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists start from one #586

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Lists start from one #586

merged 1 commit into from
Mar 9, 2024

Conversation

WillB97
Copy link
Contributor

@WillB97 WillB97 commented Mar 3, 2024

People count from one, so should our lists.

Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lists starting from 0 is intentional -- it's somewhat assumed that people may have already cloned the repo if they're reading the setup instructions.

@WillB97
Copy link
Contributor Author

WillB97 commented Mar 3, 2024

These lists starting from 0 is intentional -- it's somewhat assumed that people may have already cloned the repo if they're reading the setup instructions.

Then they just skip over the step it doesn't remove the fact that the step exists.

@WillB97 WillB97 requested a review from PeterJCLaw March 3, 2024 11:52
@RealOrangeOne
Copy link
Member

If we're going to make this change, I'd suggest actually renumbering the markdown source so the numbers are sequential.

@PeterJCLaw
Copy link
Member

If we're going to make this change, I'd suggest actually renumbering the markdown source so the numbers are sequential.

I'd actually suggest going the other way -- make them all 1. so that there's no redundant diff when changes are made. #585 actually does that as it was doing some other related tidying.

@PeterJCLaw PeterJCLaw merged commit 66a4a77 into main Mar 9, 2024
2 checks passed
@PeterJCLaw PeterJCLaw deleted the list-start branch March 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants