Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise the JSON redirects file before diffing #598

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

PeterJCLaw
Copy link
Member

@PeterJCLaw PeterJCLaw commented Aug 3, 2024

This ensures that key-ordering changes, which don't affect the semantics of the file, don't create diff noise (such as that in #597 (comment)).

Also exclude some build-time JSON files from the output.

Builds on #600 to pick up that fix.

Copy link

github-actions bot commented Aug 3, 2024

🔀 Build diff:

Only in main: cspell.json
Only in main: package-lock.json
Only in main: package.json

@PeterJCLaw PeterJCLaw changed the base branch from main to fix-docker-compose August 3, 2024 09:41
@PeterJCLaw PeterJCLaw force-pushed the fix-json-key-ordering-diffs branch 3 times, most recently from fe5aa80 to bb7bb5f Compare August 3, 2024 10:00
Base automatically changed from fix-docker-compose to main August 3, 2024 10:06
This ensures that key-ordering changes, which don't affect the
semantics of the file, don't create diff noise.
@PeterJCLaw PeterJCLaw marked this pull request as ready for review August 3, 2024 10:48
@PeterJCLaw PeterJCLaw changed the base branch from main to ensure-consistent-archival-for-diff August 3, 2024 10:49
@PeterJCLaw PeterJCLaw requested a review from raccube August 3, 2024 11:08
Base automatically changed from ensure-consistent-archival-for-diff to main August 13, 2024 19:49
@PeterJCLaw PeterJCLaw merged commit 66ba8fc into main Aug 13, 2024
6 checks passed
@PeterJCLaw PeterJCLaw deleted the fix-json-key-ordering-diffs branch August 13, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants