Move to Ruby 3 #602
Merged
Move to Ruby 3 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔀 Build diff: diff -ru main/simulator/simulated_robot.html local/simulator/simulated_robot.html
--- main/simulator/simulated_robot.html 2024-08-18 18:17:18.000000000 +0000
+++ local/simulator/simulated_robot.html 2024-08-18 18:16:55.000000000 +0000
@@ -958,7 +958,7 @@
<div class="language-python highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="n">reading</span> <span class="o">=</span> <span class="n">R</span><span class="p">.</span><span class="n">arduino</span><span class="p">.</span><span class="n">pins</span><span class="p">[</span><span class="n">A5</span><span class="p">].</span><span class="n">analog_read</span><span class="p">()</span>
<span class="c1"># convert reading from volts to meters
</span><span class="n">measurement</span> <span class="o">=</span> <span class="n">reading</span> <span class="o">/</span> <span class="p">(</span><span class="mi">5</span><span class="o">/</span><span class="mi">2</span><span class="p">)</span>
-<span class="k">print</span><span class="p">(</span><span class="sa">f</span><span class="s">"Rear ultrasound distance </span><span class="si">{</span><span class="n">measurement</span><span class="p">:.</span><span class="mi">2</span><span class="n">f</span><span class="si">}</span><span class="s"> meters"</span><span class="p">)</span>
+<span class="k">print</span><span class="p">(</span><span class="sa">f</span><span class="s">"Rear ultrasound distance </span><span class="si">{</span><span class="n">measurement</span><span class="si">:</span><span class="p">.</span><span class="mi">2</span><span class="n">f</span><span class="si">}</span><span class="s"> meters"</span><span class="p">)</span>
</code></pre></div></div>
<h3 id="leds">LEDs</h3> |
This appears to include some small changes to syntax highlighting within f-strings, though nothing which appears incorrect.
This includes updating our validation yaml loading to allow parsing date values in the kit versions file, which was previously implicitly allowed but now needs to be explicit.
raccube
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.x is fairly old and likely to hold us back from package updates. This PR updates some packages which enable us to move to Ruby 3.x and then upgrades us all the way to the latest version.
This is broadly equivalent to other updates already done to our other jekyll repos (e.g: srobo/website#550).
The package updates appear to include some small changes to syntax highlighting within f-strings, though nothing which appears incorrect.
Note: I haven't tested the setup process on Windows -- if someone is able to do that and ensure that it's easy enough to set up Ruby 3 in Windows that would be great.