Install Sphinx upfront in CI #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a hack though it fixes CI for now. It's not clear why letting setuptools install Sphinx as part of the `install_requires` dependencies doesn't work, however as we're likely going to need to rework how installs work soon anyway (since python packaging as a whole is shifting) it doesn't seem worth spending too much time on fixing it right now.
This was referenced Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack though it fixes CI for now. It's not clear why letting setuptools install Sphinx as part of the
install_requiresdependencies doesn't work, however as we're likely going to need to rework how installs work soon anyway (since python packaging as a whole is shifting) it doesn't seem worth spending too much time on fixing it right now.I think this is likely the same issue that @trickeydan hit in #52 (comment).
I've manually tested that the resulting wheel can still be installed without this hack. Likely the source build can't, however that's probably the case for the published source distribution too given that this appears to be a Sphinx/setuptools issue rather than something we've changed.
I've raised #57 to record that we have this issue, so that we can merge this PR to unblock things without forgetting that the issue exists.