Automatically calculate milestone expected ages #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses placeholder algorithm for now - calculates average score for a milestone from each age (1 month bins) - expected age is the first age with an average score >= 3 - the details of this algorithm can be refined later - resolves #133 - add view data button below expected age slider in admin edit milestone dialog - displays a plot of average scores vs age for this milestone - includes a dotted line showing the calculated expected age based on the data - add admin tab for this - displays expected age for each milestone & button to plot data - button to calculate new expected age for each - button to save changes - add @unovis/ts chart/plotting library - using @unovis/ts for now due to lack of svelte 5 support in @unovis/svelte - can switch to the svelte version once this issue is resolved - svelte-vega looked more promising but gave an error at build time - resolves #153 - add numpy to backend dependencies - remove default constructors from some models to improve generated typescript types - e.g. `milestones: list[MilestoneAdmin] = {}` used to give typescript type `MilestoneAdmin[] | undefined` - replace with `milestones: list[MilestoneAdmin]` to give `MilestoneAdmin[]`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 27.88% 27.85% -0.04%
==========================================
Files 93 96 +3
Lines 3306 3461 +155
Branches 90 93 +3
==========================================
+ Hits 922 964 +42
- Misses 2316 2426 +110
- Partials 68 71 +3 ☔ View full report in Codecov by Sentry. |
MaHaWo
approved these changes
Nov 13, 2024
|
lkeegan
deleted the
fix_133_automatically_calculate_milestone_expected_ages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
milestones: list[MilestoneAdmin] = {}used to give typescript typeMilestoneAdmin[] | undefinedmilestones: list[MilestoneAdmin]to giveMilestoneAdmin[]