Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate about page, editable in admin interface #65

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Dec 18, 2024

  • backend
    • add about_md to Settings
  • frontend
    • add About page
    • render about_md markdown using showdown to convert to html and github-markdown-css for styling
    • add text box to edit about_md in admin settings
    • refactor shared Jumbotron code into HeadingComponent
    • refactor settings api call into a settings store
  • resolves add separate about page #55
  • resolves Add Readme #34

- backend
  - add about_md to Settings
- frontend
  - add About page
  - render about_md markdown using showdown to convert to html and github-markdown-css for styling
  - add text box to edit about_md in admin settings
  - refactor shared Jumbotron code into HeadingComponent
  - refactor settings api call into a settings store
- resolves #55
- resolves #34
@lkeegan lkeegan merged commit 7c7d557 into main Dec 18, 2024
5 checks passed
@lkeegan lkeegan deleted the fix_55_add_about_page branch December 18, 2024 14:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (4ca7c34) to head (f5572d0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   78.10%   78.13%   +0.03%     
==========================================
  Files           8        8              
  Lines         717      718       +1     
==========================================
+ Hits          560      561       +1     
  Misses        157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add separate about page Add Readme
2 participants