Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action #20

Open
kirawi opened this issue Nov 28, 2021 · 5 comments
Open

GitHub action #20

kirawi opened this issue Nov 28, 2021 · 5 comments

Comments

@kirawi
Copy link

kirawi commented Nov 28, 2021

Would it be possible to create a GitHub action for using Rudra?

@Qwaz
Copy link
Member

Qwaz commented Nov 30, 2021

In terms of technical possibility - certainly! If you are asking if there is an off-the-shelf GitHub action provided right now, then unfortunately not yet.

FYI, two of the most common bug templates (uninit_vec and non_send_fields_in_send_ty) have been ported as Clippy lints, so I think you can start enabling Clippy in your environment.

@GeekMasher
Copy link
Contributor

@kirawi I thought the exact same thing so I created this PR #21

Only basic support was added and more of the arguments that you might want to pass in aren't supported but its a start.

@Qwaz
Copy link
Member

Qwaz commented Jan 5, 2022

Partially fixed by #21. I'll keep this issue open until we release an official GitHub Actions on the marketplace.

@Qwaz
Copy link
Member

Qwaz commented Jan 5, 2022

Thanks a lot @GeekMasher for the initial integration :D

@gkorland
Copy link

Can the rust version be upgraded?
Getting this error:

2022-07-31 09:27:34.958344 |ERROR| [rudra-progress] Could not obtain Cargo metadata
Error during execution of `cargo metadata`:     Updating git repository `[https://github.com/RedisJSON/jsonpath.git`](https://github.com/RedisJSON/jsonpath.git%60)
    Updating crates.io index
 Downloading crates ...
  Downloaded addr2line v0.17.0
  Downloaded indexmap v1.9.1
error: failed to parse manifest at `/usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/indexmap-1.9.1/Cargo.toml`

Caused by:
  feature `edition2021` is required

  The package requires the Cargo feature called `edition2021`, but that feature is not stabilized in this version of Cargo (1.56.0-nightly (e96bdb0c3 2021-08-17)).
  Consider trying a more recent nightly release.
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2021 for more information about the status of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants